RFR: 8302511: HitInfo.toString() throws IllegalArgumentException

Karthik P K kpk at openjdk.org
Thu Jun 15 14:45:02 UTC 2023


On Wed, 14 Jun 2023 15:40:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> A recent change in JDK-8304831 ensured that insertionIndex is always computed prior to HitInfo construction, making it possible to remove buggy logic in HitInfo.  This change also allows for removal of the 'text' field. 
> 
> There should be no impact since the constructor is package protected.

The fix looks good to me.
Can we add a test to verify the changes?
Another minor comment: copyright year can be updated in Text.java as well.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1154#pullrequestreview-1481756712


More information about the openjfx-dev mailing list