RFR: 8302511: HitInfo.toString() throws IllegalArgumentException [v2]

[Andy Goryachev]

> A recent change in JDK-8304831 ensured that insertionIndex is always computed prior to HitInfo construction, making it possible to remove buggy logic in HitInfo.  This change also allows for removal of the 'text' field. 
> 
> There should be no impact since the constructor is package protected.

Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:

  review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1154/files
  - new: https://git.openjdk.org/jfx/pull/1154/files/c2685ba7..8014ba33

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1154&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1154&range=00-01

  Stats: 163 lines in 3 files changed: 140 ins; 7 del; 16 mod
  Patch: https://git.openjdk.org/jfx/pull/1154.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1154/head:pull/1154

PR: https://git.openjdk.org/jfx/pull/1154