RFR: 8302511: HitInfo.toString() throws IllegalArgumentException [v2]
Andy Goryachev
angorya at openjdk.org
Thu Jun 15 18:42:19 UTC 2023
On Thu, 15 Jun 2023 14:42:43 GMT, Karthik P K <kpk at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comments
>
> The fix looks good to me.
> Can we add a test to verify the changes?
> Another minor comment: copyright year can be updated in Text.java as well.
thank you for the suggestions, @karthikpandelu !
- modified TextFlowSurrogatePaitInsertionIndexTest to test for invariants
- added a similar test for Text
- updated copyright year
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1154#issuecomment-1593554489
More information about the openjfx-dev
mailing list