RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow
Andy Goryachev
angorya at openjdk.org
Wed Jun 21 23:02:12 UTC 2023
On Wed, 21 Jun 2023 06:34:00 GMT, Karthik P K <kpk at openjdk.org> wrote:
> The text run selected in `PrismTextLayout::getHitInfo()` method for character index calculation was not correct when Text node was embedded in TextFlow. Hence wrong character index value was calculated for the same.
>
> Since only x, y coordinates were available in the above mentioned method, sending the text as a parameter to this method is necessary so as to know if the text run selected for character index calculation is correct. Along with this change modified the `PrismTextLayout::getHitInfo()` method to calculate the correct character index.
>
> Added tests to validate the changes.
Looks like Text.hitTest() does not return the right information (charIndex=0, leading) for text on either the second line, or a wrapped line. (mouse over over 2nd/3rd lines):

-------------
PR Comment: https://git.openjdk.org/jfx/pull/1157#issuecomment-1601798335
More information about the openjfx-dev
mailing list