RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v2]

Karthik P K kpk at openjdk.org
Tue Jun 27 16:06:20 UTC 2023


On Tue, 27 Jun 2023 15:30:39 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> The text run selected in `PrismTextLayout::getHitInfo()` method for character index calculation was not correct when Text node was embedded in TextFlow. Hence wrong character index value was calculated for the same.
>> 
>> Since only x, y coordinates were available in the above mentioned method, sending the text as a parameter to this method is necessary so as to know if the text run selected for character index calculation is correct. Along with this change modified the `PrismTextLayout::getHitInfo()` method to calculate the correct character index.
>> 
>> Added tests to validate the changes.
>
> Karthik P K has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Resolve merge conflict
>  - Fix character index calculation issue in Text node embedded in TextFlow

Fixed issue with wrapped text.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1157#issuecomment-1609815252


More information about the openjfx-dev mailing list