RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v2]
Andy Goryachev
angorya at openjdk.org
Fri Jun 30 15:43:06 UTC 2023
On Fri, 30 Jun 2023 05:38:03 GMT, Karthik P K <kpk at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ResizeHelper.java line 112:
>
>> 110: distribute(delta, pref);
>> 111: }
>> 112: } else if (delta > 0.0) {
>
> Do we need delta = 0.0 condition here?
excellent question. we don't - zero delta means no change, so no action is needed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1156#discussion_r1248011392
More information about the openjfx-dev
mailing list