RFR: 8300872: WebView's ColorChooser fails to initialize when running in security context [v3]
Jose Pereda
jpereda at openjdk.org
Fri Mar 3 19:22:04 UTC 2023
> This PR removes an unnecessary check that was added as part of [JDK-8267551](https://bugs.openjdk.org/browse/JDK-8267551).
>
> As commented in the [issue](https://bugs.openjdk.org/browse/JDK-8300872), there were no failing/passing tests before/after these lines were added, and there are no actual tests that get into the case.
>
> The mentioned check caused, as a side effect, the JDK-8300872 issue, as running under a (deprecated) security manager fails with:
>
> java.security.AccessControlException: access denied ("java.io.FilePermission" "jrt:/javafx.controls/com/sun/javafx/scene/control/skin/modena/pattern-transparent.png" "read")
> ...
> at javafx.graphics/javafx.scene.image.Image.validateUrl(Image.java:1127)
> ...
>
> when `File::exists` is evaluated over an image bundled in a jar.
Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
Address feedback
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1042/files
- new: https://git.openjdk.org/jfx/pull/1042/files/ba7aef23..51108c4a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1042&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1042&range=01-02
Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jfx/pull/1042.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/1042/head:pull/1042
PR: https://git.openjdk.org/jfx/pull/1042
More information about the openjfx-dev
mailing list