RFR: 8260528: Clean glass-gtk sizing and positioning code [v55]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Mar 6 23:18:29 UTC 2023


On Sat, 4 Mar 2023 17:45:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix bug when window starts maximized and restores to wrong size
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 819:
> 
>> 817: void WindowContextTop::request_frame_extents() {
>> 818:     Display *display = GDK_DISPLAY_XDISPLAY(gdk_window_get_display(gdk_window));
>> 819:     static Atom rfeAtom = XInternAtom(display, "_NET_REQUEST_FRAME_EXTENTS", False);
> 
> If display could be different for two Windows, then making this static would not be the right thing to do. I don't think it can, so this is probably OK.

Atoms are per server, so I also think it's ok.

-------------

PR: https://git.openjdk.org/jfx/pull/915


More information about the openjfx-dev mailing list