RFR: 8303740 JavaFX - Leak in Logging, Logging remembers last exception

Kevin Rushforth kcr at openjdk.org
Sat Mar 11 14:44:29 UTC 2023


On Wed, 8 Mar 2023 08:19:25 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> IMHO, the `Logging` class should also not be there, as it is just a facade for `PlatformLogger` specifically there for these tests.
> 
> The tests took the easy way out here to test for log messages by modifying production code to use a different logger (and introducing a leak by doing so). An alternative would be to install a `LoggerFinder` only when tests run, and allow this to be inspected.

This seems like an even better solution for the follow-up fix. The current approach of using a custom Logger in production, just for tests is undesirable.

-------------

PR: https://git.openjdk.org/jfx/pull/1053


More information about the openjfx-dev mailing list