RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics

[Kevin Rushforth]

On Thu, 16 Mar 2023 06:31:04 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java line 2102:
>> 
>>> 2100:      ********************************************************************/
>>> 2101: 
>>> 2102:     //Test for JDK-8172849
>> 
>> minor: I would have used a javadoc comment instead of the big comment block
>> /** Test for JDK-8172849 */
>
> Yes javadoc comment would look better. I used the comment block to keep it consistent with the other comments present in the same file. I think if changing, then better to change all the comment blocks in the file.
> Please let me know your thoughts.

Please don't change all of the other comment blocks as part of this PR. You can file a follow-up bug if you like, but in that case, we should first define a "best practice", probably something that would align with what the JDK's jtreg test harness expects. So I think this can be left as-is for now.

-------------

PR: https://git.openjdk.org/jfx/pull/1059