RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics

Karthik P K kpk at openjdk.org
Thu Mar 16 12:35:30 UTC 2023


On Thu, 16 Mar 2023 12:14:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Yes javadoc comment would look better. I used the comment block to keep it consistent with the other comments present in the same file. I think if changing, then better to change all the comment blocks in the file.
>> Please let me know your thoughts.
>
> Please don't change all of the other comment blocks as part of this PR. You can file a follow-up bug if you like, but in that case, we should first define a "best practice", probably something that would align with what the JDK's jtreg test harness expects. So I think this can be left as-is for now.

Sure Kevin. I'll keep the comments as-is and file a follow-up bug for this.

-------------

PR: https://git.openjdk.org/jfx/pull/1059


More information about the openjfx-dev mailing list