RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

[Michael Strauß]

On Thu, 16 Mar 2023 19:15:25 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - changes per review
>>  - Merge branch 'master' into fixes/box-snap-to-pixel
>>    
>>    # Conflicts:
>>    #	modules/javafx.graphics/src/test/java/test/javafx/scene/layout/HBoxTest.java
>>    #	modules/javafx.graphics/src/test/java/test/javafx/scene/layout/VBoxTest.java
>>  - Merge branch 'openjdk:master' into fixes/box-snap-to-pixel
>>  - revert snappedSum
>>  - don't call snappedSum in hot loop
>>  - Improved code documentation
>>  - Merge branch 'master' into fixes/box-snap-to-pixel
>>  - changed some method names, make test config a local class
>>  - added documentation, improved method names
>>  - Merge branch 'master' into fixes/box-snap-to-pixel
>>  - ... and 2 more: https://git.openjdk.org/jfx/compare/a35c3bf7...fbbc273a
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HBox.java line 583:
> 
>> 581:         // distribute (currentDelta), as well as children that are eligible to grow or
>> 582:         // shrink (adjustingNumber).
>> 583:         while ((currentDelta > Double.MIN_VALUE || currentDelta < -Double.MIN_VALUE) && adjustingNumber > 0) {
> 
> is there a guarantee that this while loop ends?

Yes, in line 612 we return from this method once we can't resize any further.

-------------

PR: https://git.openjdk.org/jfx/pull/445