RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics [v2]

Karthik P K kpk at openjdk.org
Fri Mar 17 06:12:11 UTC 2023


On Thu, 16 Mar 2023 06:32:30 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java line 2136:
>> 
>>> 2134:      *                                                                              *
>>> 2135:      *******************************************************************************/
>>> 2136: 
>> 
>> Minor: I would have used a javadoc explaining the purpose of this class instead of generic "Helper classes".
>
> Same comment as above. In addition to that, yes, updating the comment with actual purpose of the class would be better. I will update that once we decide if all the other comment blocks also should be changed or not.
> Since there was no comment for this class, I added the comment so that it gets separated from "Tests for bug reports" tests.

Updated the comment with purpose of the class instead of generic comment.

-------------

PR: https://git.openjdk.org/jfx/pull/1059


More information about the openjfx-dev mailing list