RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics [v2]

Andy Goryachev angorya at openjdk.org
Fri Mar 17 16:26:59 UTC 2023


On Fri, 17 Mar 2023 06:12:07 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Issue was observed because even when graphic height was less than text height of the Label, graphic height was considered while calculating the baseline offset. This was shifting the baseline offset and resulted in misalignment.
>> 
>> Updated `computeBaselineOffset` to exclude graphic height from baseline offset calculation when graphic height is more than text height.
>> 
>> Added unit test to validate the fix.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update comment

lgtm

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/1059


More information about the openjfx-dev mailing list