RFR: 8154038: Spinner's converter should update its editor [v2]

Ajit Ghaisas aghaisas at openjdk.org
Mon Mar 20 08:59:38 UTC 2023


On Thu, 16 Mar 2023 06:09:03 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> When converter was changed, `setText` method of spinner was not invoked to update the spinner text using new converter.
>> 
>> Added a listener to converter property of `SpinnerValueFactory` to call `setText` so that spinner text is updated using new converter.
>> 
>> Added unit test to validate the fix. Along with spinner of Double type, added a spinner of Integer type as well so that the fix is validated using 2 types of spinner.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Looks good!

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/1057


More information about the openjfx-dev mailing list