RFR: 8303740 JavaFX - Leak in Logging, Logging remembers last exception [v2]
Florian Kirmaier
fkirmaier at openjdk.org
Thu Mar 23 08:31:41 UTC 2023
> When an exception is logged in JavaFX, then the exception is kept in a reference.
> This way, always the last logged exception is retained.
>
> This is a memory-leak.
> This was done to write unit-tests to ensure certain error-cases are logged.
>
> A simple fix is, to add a flag, to enable/disable retaining the exception.
Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
JDK-8303740
Added changes based on code review
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1053/files
- new: https://git.openjdk.org/jfx/pull/1053/files/1fe0d464..ad34efb7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1053&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1053&range=00-01
Stats: 45 lines in 3 files changed: 41 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jfx/pull/1053.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1053/head:pull/1053
PR: https://git.openjdk.org/jfx/pull/1053
More information about the openjfx-dev
mailing list