Integrated: 8172849: Non-intuitive baseline alignment for labeled controls with graphics
Karthik P K
kpk at openjdk.org
Thu Mar 23 11:36:53 UTC 2023
On Wed, 15 Mar 2023 10:58:14 GMT, Karthik P K <kpk at openjdk.org> wrote:
> Issue was observed because even when graphic height was less than text height of the Label, graphic height was considered while calculating the baseline offset. This was shifting the baseline offset and resulted in misalignment.
>
> Updated `computeBaselineOffset` to exclude graphic height from baseline offset calculation when graphic height is more than text height.
>
> Added unit test to validate the fix.
This pull request has now been integrated.
Changeset: ae2e71fc
Author: Karthik P K <kpk at openjdk.org>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/ae2e71fc5ac2e6c7cf6d671c15b53249783c71b3
Stats: 50 lines in 2 files changed: 47 ins; 0 del; 3 mod
8172849: Non-intuitive baseline alignment for labeled controls with graphics
Reviewed-by: angorya, aghaisas
-------------
PR: https://git.openjdk.org/jfx/pull/1059
More information about the openjfx-dev
mailing list