RFR: JDK-8304959: Public API in javafx.css.Match should not return private API class PseudoClassState

Kevin Rushforth kcr at openjdk.org
Mon Mar 27 15:59:18 UTC 2023


On Mon, 27 Mar 2023 15:40:47 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> The class `PseudoClassState` is private API, but was exposed erroneously in the CSS API. Instead, `Set<PseudoClass>` should have been used. This PR corrects this.
>
> modules/javafx.graphics/src/main/java/javafx/css/Match.java line 79:
> 
>> 77:      * @return the pseudo class state
>> 78:      */
>> 79:     public Set<PseudoClass> getPseudoClasses() {
> 
> does this change need a CSR?

Yes, thanks for checking. I already flagged it as needing a CSR.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1070#discussion_r1149465925


More information about the openjfx-dev mailing list