RFR: JDK-8304960: ObservableListBase should defer constructing ListChangeBuilder
Marius Hanl
mhanl at openjdk.org
Thu Mar 30 10:29:31 UTC 2023
On Wed, 29 Mar 2023 12:15:02 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
> A 1200 Node application sees a 2/3rds reduction of ListChangeBuilder's created. Every `Node` for example has an `ObservableList` for style classes, and every `Parent` has one for stylesheets, which rarely if ever change.
Looks good to me too and makes sense.
This also aligns well with the `listenerHelper`, which is also created when needed.
-------------
Marked as reviewed by mhanl (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1075#pullrequestreview-1364806283
More information about the openjfx-dev
mailing list