RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v3]

Ambarish Rapte arapte at openjdk.org
Tue May 2 08:57:32 UTC 2023


On Fri, 28 Apr 2023 11:44:37 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update submit.yml
>
> build.gradle line 55:
> 
>> 53:  *
>> 54:  * Adding a new project or task:
>> 55:  *  - Fix for JDK-XXXXXXX, introduces a restriction on assigning name for project or task.
> 
> Minor: replace with actual bug ID (8297071)

Corrected.

> build.gradle line 57:
> 
>> 55:  *  - Fix for JDK-XXXXXXX, introduces a restriction on assigning name for project or task.
>> 56:  *    - If the name of project or task contains word test/Test then it is considered as test task.
>> 57:  *    - If the name of project or task contains word shim/Shim then it is considered as shims task.
> 
> Minor: there is no project that contains the name `shim`, so I think you can remove the "project or" from this comment.

Corrected.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1117#discussion_r1182265837
PR Review Comment: https://git.openjdk.org/jfx/pull/1117#discussion_r1182266003


More information about the openjfx-dev mailing list