RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility [v2]

[Lukasz Kostyra]

On Tue, 2 May 2023 15:49:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review issues
>>   
>>   * JMemoryBuddy now has helpers for arrays of WeakReference, ArrayList
>>     of WeakReference and vararg WeakReferences
>>   * Updated copyright years in some files which were missed in previous
>>     changes
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 101:
> 
>> 99:     }
>> 100: 
>> 101:     public static <T> void assertCollectable(ArrayList<WeakReference<T>> weakReferences) {
> 
> Could we change the argument to Collection<...>?

Done

> modules/javafx.web/src/test/java/test/javafx/scene/web/LeakTest.java line 95:
> 
>> 93: 
>> 94:         for (WeakReference ref : willGC) {
>> 95:             JMemoryBuddy.assertCollectable(ref);
> 
> should we use newly added methods here?

Done + others.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1183435309
PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1183435289