RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v5]
John Hendrikx
jhendrikx at openjdk.org
Thu May 4 09:55:28 UTC 2023
On Thu, 27 Apr 2023 15:23:33 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix NaN returns when using Math.ulp
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line 310:
>
>> 308: private static double scaledFloor(double value, double scale) {
>> 309: double d = value * scale;
>> 310:
>
> could we get rid of this newline - here and on lines 330, 413 please?
It's the style I use, I tend to separate assignment, declaration and other code.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1118#discussion_r1184800203
More information about the openjfx-dev
mailing list