RFR: 8307208: Add GridPane constructor that accepts hGap and vGap values [v2]

Kevin Rushforth kcr at openjdk.org
Fri May 5 11:46:23 UTC 2023


On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the creation of a layout involving a `GridPane` without FXML.
>> In my experience, the `hgap` and the `vgap` are almost always set when creating a layout with the `GridPane`, as a space between the content just looks much better.
>> 
>> This also fits well with other classes like `HBox` and `VBox`, which also provide a constructor that accepts the spacing.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8307208: Improve javadoc and change copyright year

Looks good. I reviewed the CSR, so you can Finalize it now.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1125#pullrequestreview-1414634331


More information about the openjfx-dev mailing list