RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility [v5]

[Lukasz Kostyra]

On Fri, 5 May 2023 12:22:03 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JMemoryBuddy: Add javadoc comments
>>  - Remove thread sleeps before JMemoryBuddy calls
>>    
>>    JMemoryBuddy performs sleeps to check if objects are collectable by
>>    itself, there is no reason to do those.
>
> tests/system/src/test/java/test/javafx/embed/swing/SwingNodeMemoryLeakTest.java line 80:
> 
>> 78:         });
>> 79: 
>> 80:         JMemoryBuddy.assertCollectable(weakRefArrSN);
> 
> On my Mac (MacBook Pro x64 running macOS 13.2.1) I saw a one-time test failure here. So there might be a need to wait for the EDT to at least do something, possibly followed by a sleep (on the test thread, not on the EDT).

Interesting, I will add a `runAndWait()` noop and a test thread sleep then.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1186045625