RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility [v3]

[Lukasz Kostyra]

On Wed, 3 May 2023 18:15:34 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor review updates
>>   
>>   * Changed ArrayList<> to Collection<> in one of assertCollectable-s
>>   * Updated LeakTest to use new assertCollectable helpers
>
> The changes look good!
> Unfortunately, the project won't build in Eclipse due to
> 
> `The type test.util.memory.JMemoryBuddy is not accessible	LeakTest.java	/web/src/test/java/test/javafx/scene/web`
> 
> To fix that, could you please modify line 45 of modules/web/.classpath file to this (er, better include the whole file):
> 
> 
> <?xml version="1.0" encoding="UTF-8"?>
> <classpath>
> 	<classpathentry kind="src" path="src/main/java"/>
> 	<classpathentry kind="src" path="src/main/native/Source/WebCore/bindings/java/dom3/java"/>
> 	<classpathentry kind="src" output="testbin" path="src/shims/java">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="src" output="testbin" path="src/test/java">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 			<attribute name="optional" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="src" path="src/main/resources">
> 		<attributes>
> 			<attribute name="optional" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="src" output="testbin" path="src/test/resources">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 			<attribute name="optional" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry combineaccessrules="false" kind="src" path="/media">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry combineaccessrules="false" kind="src" path="/controls">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry combineaccessrules="false" kind="src" path="/graphics">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry combineaccessrules="false" kind="src" path="/base">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 			<attribute name="add-exports" value="javafx.base/com.sun.javafx=javafx.web:javafx.base/test.util.memory=javafx.web"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/5">
> 		<attributes>
> 			<attribute name="test" value="true"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 			<attribute name="add-reads" value="javafx.web=java.management"/>
> 		</attributes>
> 	</classpathentry>
> 	<classpathentry kind="output" path="bin"/>
> </classpath>

@andy-goryachev-oracle I'll wait for your last look at it before I integrate it

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1121#issuecomment-1536408063