RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v6]
Thiago Milczarek Sayao
tsayao at openjdk.org
Sat May 6 20:31:27 UTC 2023
> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this scroll event type, deltas are sent to java with the value equal to zero.
>
> Here's whats happening:
>
> We include all event masks, so when using gtk3 (>= 3.4.0) it includes `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction (UP/DOWN).
>
> When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored it causing it to send deltas (x,y) = 0.
>
> The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also adding smooth scroll functionality.
Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 38 additional commits since the last revision:
- Merge branch 'master' into fix_scrolling
- Improve direction
- Rename var
- Fix direction
- Fix for Ubuntu 20.04
- Fix scroll event
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- ... and 28 more: https://git.openjdk.org/jfx/compare/09166e0f...80285aef
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1044/files
- new: https://git.openjdk.org/jfx/pull/1044/files/a3975da3..80285aef
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=05
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=04-05
Stats: 20380 lines in 497 files changed: 11008 ins; 7486 del; 1886 mod
Patch: https://git.openjdk.org/jfx/pull/1044.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1044/head:pull/1044
PR: https://git.openjdk.org/jfx/pull/1044
More information about the openjfx-dev
mailing list