RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v8]

Thiago Milczarek Sayao tsayao at openjdk.org
Sat May 6 21:22:28 UTC 2023


> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this scroll event type, deltas are sent to java with the value equal to zero.
> 
> Here's whats happening:
> 
> We include all event masks, so when using gtk3 (>= 3.4.0) it includes `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with  `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction (UP/DOWN).
> 
> When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored it causing it to send deltas (x,y) = 0.
> 
> The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also adding smooth scroll functionality.

Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 40 additional commits since the last revision:

 - Merge branch 'master' into fix_scrolling
 - Remove print statement
 - Merge branch 'master' into fix_scrolling
 - Improve direction
 - Rename var
 - Fix direction
 - Fix for Ubuntu 20.04
 - Fix scroll event
 - Merge branch 'openjdk:master' into master
 - Merge branch 'openjdk:master' into master
 - ... and 30 more: https://git.openjdk.org/jfx/compare/c2c1a95d...dad897aa

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1044/files
  - new: https://git.openjdk.org/jfx/pull/1044/files/15423b0c..dad897aa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=07
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1044&range=06-07

  Stats: 7683 lines in 75 files changed: 7412 ins; 136 del; 135 mod
  Patch: https://git.openjdk.org/jfx/pull/1044.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1044/head:pull/1044

PR: https://git.openjdk.org/jfx/pull/1044


More information about the openjfx-dev mailing list