RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility [v6]

Lukasz Kostyra lkostyra at openjdk.org
Mon May 8 08:49:17 UTC 2023


On Fri, 5 May 2023 16:13:39 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add an EDT no-op and sleep for a bit
>>   
>>   On some platforms Swing memory leak tests occasionally failed, this
>>   might help to mitigate this problem.
>
> modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 96:
> 
>> 94: 
>> 95:     /**
>> 96:      * Checks whether an array of WeakReference objects can be collected.
> 
> I think it should rather say something like "whether content of all references in the array", rather than array itself.

Done (+ others)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1121#discussion_r1187188130


More information about the openjfx-dev mailing list