RFR: 8278422: Replace use of deprecated single string variant of Runtime.exec method

[Nir Lisker]

On Tue, 9 May 2023 17:54:35 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Calls of `Runtime.getRuntime().exec()` were changed to `String[]` variant.
>> 
>> Only Windows and macOS parts were affected, tests work good on both platforms.
>> 
>> I looked through the code and didn't find any other cases of `Runtime.getRuntime().exec(String)` being used, so that should cover all possible deprecation warnings for this issue.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/HostServicesDelegate.java line 138:
> 
>> 136:             try {
>> 137:                 if (osName.startsWith("Mac OS")) {
>> 138:                     Runtime.getRuntime().exec(new String[] {
> 
> not a review, but a general question:
> do we have (do we want) an enum identifying the platform?

Don't think we have an enum (maybe we should), but `PlatformUtil` already takes care of identifying the OS, also using `System.getProperty("os.name")`. You can use `PlatformUtil.isMac()`. If we make an enum, that's where is should be.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1130#discussion_r1188981353