RFR: 8307538: Memory leak in TreeTableView when calling refresh [v2]

John Hendrikx jhendrikx at openjdk.org
Wed May 10 07:03:26 UTC 2023


On Tue, 9 May 2023 22:41:41 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - removed monkey tester changes
>>  - Merge remote-tracking branch 'origin/master' into 8307538.refresh
>>  - whitespace
>>  - updated test
>>  - variable tree cell fix
>>  - fixed size selector
>>  - list view page
>>  - fix and test
>>  - skin menu
>>  - refresh button
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java line 215:
> 
>> 213:         int right = 23;
>> 214:         int bottom = 37;
>> 215:         int left = 49;
> 
> After the fix and test change, this test now fails for me.

I'm not quite seeing why these changes are needed.  How are they related to the memory leak?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1189436860


More information about the openjfx-dev mailing list