RFR: 8307363: TextFlow.underlineShape() [v2]

Andy Goryachev angorya at openjdk.org
Wed May 10 20:48:22 UTC 2023


> Adding TextFlow.underlineShape() to add support for a spellchecker-like decoration, using 
> 
> getRange(start, end, TextLayout.TYPE_UNDERLINE);
> 
> 
> which mirrors an existing method in Text with exactly the same signature.

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into 8307363.underline
 - added test
 - use the same javadoc as in Text
 - whitespace
 - 8307363: text flow underline shape

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1127/files
  - new: https://git.openjdk.org/jfx/pull/1127/files/7a1aa4ef..53ad2540

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1127&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1127&range=00-01

  Stats: 1496 lines in 21 files changed: 1300 ins; 136 del; 60 mod
  Patch: https://git.openjdk.org/jfx/pull/1127.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1127/head:pull/1127

PR: https://git.openjdk.org/jfx/pull/1127


More information about the openjfx-dev mailing list