RFR: 8307363: TextFlow.underlineShape() [v2]
Andy Goryachev
angorya at openjdk.org
Wed May 10 23:32:06 UTC 2023
On Wed, 10 May 2023 23:12:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'master' into 8307363.underline
>> - added test
>> - use the same javadoc as in Text
>> - whitespace
>> - 8307363: text flow underline shape
>
> tests/system/src/test/java/test/javafx/scene/text/TextFlowNodeTest.java line 57:
>
>> 55: } catch (InterruptedException ex) {
>> 56: Assert.fail("Unexpected exception: " + ex);
>> 57: }
>
> Can this be replaced with `Util.startup()`?
"shoemaker's children go barefoot"
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1127#discussion_r1190472245
More information about the openjfx-dev
mailing list