RFR: 8307363: TextFlow.underlineShape() [v3]

Kevin Rushforth kcr at openjdk.org
Thu May 11 13:52:49 UTC 2023


On Wed, 10 May 2023 23:32:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adding TextFlow.underlineShape() to add support for a spellchecker-like decoration, using 
>> 
>> getRange(start, end, TextLayout.TYPE_UNDERLINE);
>> 
>> 
>> which mirrors an existing method in Text with exactly the same signature.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1127#pullrequestreview-1422641869


More information about the openjfx-dev mailing list