RFR: JDK-8307807 Replace use of System.getProperty("os.name") with PlatformUtil calls [v3]

Kevin Rushforth kcr at openjdk.org
Thu May 11 17:16:56 UTC 2023


On Thu, 11 May 2023 16:30:58 GMT, Carl Döbbelin <duke at openjdk.org> wrote:

>> Replaced querying of `System.getProperty("os.name")` to check for OS with the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   added export of javafx.base to javafx.web and added platform utils call in urlloader

Looks OK with two comments.

.idea/jarRepositories.xml line 1:

> 1: <?xml version="1.0" encoding="UTF-8"?>

This is not relevant to the bug fix. You need to revert the addition of this file.

modules/javafx.base/src/main/java/module-info.java line 53:

> 51:         javafx.fxml,
> 52:         javafx.media,
> 53:         javafx.swing, javafx.web;

Minor: can you move `javafx.web` onto its own line to match the formatting in the rest of the file?

-------------

PR Review: https://git.openjdk.org/jfx/pull/1132#pullrequestreview-1423080447
PR Review Comment: https://git.openjdk.org/jfx/pull/1132#discussion_r1191473561
PR Review Comment: https://git.openjdk.org/jfx/pull/1132#discussion_r1191472455


More information about the openjfx-dev mailing list