RFR: 8295078: TextField blurry when inside an TitledPane -> AnchorPane [v4]
Andy Goryachev
angorya at openjdk.org
Thu May 11 20:01:46 UTC 2023
On Mon, 8 May 2023 18:56:43 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>>
>> - 8295078: Snap anchors as well
>> - Merge branch 'master' of https://github.com/openjdk/jfx into 8295078-textfield-blurry
>>
>> Conflicts:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/AnchorPaneTest.java
>> - 8295078: Replace JUnit4 with Junit5 imports
>> - 8295078: Adjusted Copyright year
>> - 8295078: TextField blurry when inside an TitledPane -> AnchorPane
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java line 342:
>
>> 340: private double computeChildWidth(Node child, Double leftAnchor, Double rightAnchor, double areaWidth, double height) {
>> 341: if (leftAnchor != null && rightAnchor != null && child.isResizable()) {
>> 342: return areaWidth - snappedLeftInset() - snappedRightInset() - leftAnchor - rightAnchor;
>
> should this line (and line 349) use snapped left/right anchors values?
it is not immediately clear that left/right anchors are snapped.
areaWidth, however, is not.
should it be snappedSize?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/910#discussion_r1191631451
More information about the openjfx-dev
mailing list