RFR: 8299348: Size-restricted window can be observed with incorrect dimensions

[Marius Hanl]

On Mon, 26 Dec 2022 03:03:50 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> On Windows, a `Stage` that is restricted by minimum and maximum sizes can briefly be observed to appear with incorrect dimensions when it is first shown. The root cause of this bug is that the native `WinWindow._setBounds` method doesn't respect min/max sizes when calculating the window rect.
> 
> Note to reviewers: I've removed the unused `GlassWindow::updateMinMaxSize` method as to not confuse readers where min-max handling actually happens.

LGTM, left some minor comments.

modules/javafx.graphics/src/main/native-glass/win/GlassWindow.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.

minor: this can be updated now 😄

modules/javafx.graphics/src/main/native-glass/win/GlassWindow.h line 2:

> 1: /*
> 2:  * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.

minor: this can be updated now 😄

tests/system/src/test/java/test/com/sun/glass/ui/InitialWindowSizeTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.

minor: this can be updated now 😄

tests/system/src/test/java/test/com/sun/glass/ui/InitialWindowSizeTest.java line 40:

> 38: import java.util.concurrent.CountDownLatch;
> 39: 
> 40: import static org.junit.Assert.*;

Since this is a new test class, I would recommend rather using JUnit5 (`org.junit.jupiter`).

-------------

PR Review: https://git.openjdk.org/jfx/pull/984#pullrequestreview-1423350088
PR Review Comment: https://git.openjdk.org/jfx/pull/984#discussion_r1191639496
PR Review Comment: https://git.openjdk.org/jfx/pull/984#discussion_r1191639448
PR Review Comment: https://git.openjdk.org/jfx/pull/984#discussion_r1191637781
PR Review Comment: https://git.openjdk.org/jfx/pull/984#discussion_r1191639048