RFR: JDK-8307807 Replace use of System.getProperty("os.name") with PlatformUtil calls [v5]

Nir Lisker nlisker at openjdk.org
Thu May 11 20:13:39 UTC 2023


On Thu, 11 May 2023 17:59:48 GMT, Carl Döbbelin <duke at openjdk.org> wrote:

>> Replaced querying of `System.getProperty("os.name")` to check for OS with the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Delete jarRepositories.xml

Looks good. Do you want to replace `HostUtils`'s OS detection with `PlatformUtil` (or were they split on purpose)?

modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java line 388:

> 386: 
> 387:         if (clz == null && PlatformUtil.isMac()
> 388:                     && Normalizer.isNormalized(className, Normalizer.Form.NFD)) {

Can also be in 1 line.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1132#pullrequestreview-1423355943
PR Review Comment: https://git.openjdk.org/jfx/pull/1132#discussion_r1191639526


More information about the openjfx-dev mailing list