RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]
Ambarish Rapte
arapte at openjdk.org
Fri May 12 10:36:12 UTC 2023
> Issue:
> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
> The state of this CheckBox is not visible to an accessibility client application.
> If we analyze a simple program that contains a CheckBoxTreeItem using a windows application "Accessibility Insights for Window", we can notice that toggle state of CheckBox is not exposed.
>
> Fix:
> Include the [Toggle Control Pattern](https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtoggle) in Accessibility information of a CheckBoxTreeItem in addition to the patterns that are used for a TreeItem.
>
> Verification:
> On Windows: Do the following with and without the fix.
> 1. Run the sample program attached to JBS issue.
> 2. Launch "Accessibility Insights for Window"
> 3. Observe that patterns section for each item
> 4. Select / de-select the CheckBoxes and observe the patterns section for correctness of toggle state.
Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'master' into a11y-8284542-CheckBoxTreeItem
- Review Comment: Add enum ToggleState
- Add CheckBoxTreeItem role and TOGGLE_STATE attribute
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1088/files
- new: https://git.openjdk.org/jfx/pull/1088/files/b5beba53..2d89e9fb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1088&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1088&range=01-02
Stats: 11728 lines in 134 files changed: 10044 ins; 1404 del; 280 mod
Patch: https://git.openjdk.org/jfx/pull/1088.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1088/head:pull/1088
PR: https://git.openjdk.org/jfx/pull/1088
More information about the openjfx-dev
mailing list