RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop
Lukasz Kostyra
lkostyra at openjdk.org
Fri May 12 11:58:52 UTC 2023
On Thu, 11 May 2023 16:24:20 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassDraggingSource.m line 44:
>>
>>> 42: return self->dragOperation;
>>> 43: }
>>> 44:
>>
>> `sourceOperationMaskForDraggingContext` replaces the deprecated `draggingSourceOperationMaskForLocal:` over in GlassViewDelegate.m. There's some logic there that needs to be copied over here. Basically the Apple documentation on how the Cmd key filters the set of available operations doesn't match reality and we have to compensate for that.
>
> This sounds like it could be the reason for the functional regression in handling the CMD modifier while dragging.
Good catch, I'll take a look into that
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1089#discussion_r1192270396
More information about the openjfx-dev
mailing list