RFR: JDK-8307807 Replace use of System.getProperty("os.name") with PlatformUtil calls [v6]

Andy Goryachev angorya at openjdk.org
Fri May 12 14:48:54 UTC 2023


On Thu, 11 May 2023 20:19:38 GMT, Carl Döbbelin <duke at openjdk.org> wrote:

>> Replaced querying of `System.getProperty("os.name")` to check for OS with the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   made launcherimpl one line

modules/javafx.graphics/src/main/java/com/sun/glass/ui/Platform.java line 67:

> 65:             }
> 66: 
> 67:             if (PlatformUtil.isMac()) {

this change might be ok, but it is not strictly equivalent.
before, MAC path would be selected if os.name lowercase starts from either "mac" or "darwin", after the change, only starts with "Mac".
Do we want to support "darwin"?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1132#discussion_r1192471257


More information about the openjfx-dev mailing list