RFR: 8307538: Memory leak in TreeTableView when calling refresh [v4]

Andy Goryachev angorya at openjdk.org
Fri May 12 15:47:56 UTC 2023


On Fri, 12 May 2023 08:15:50 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   one more test case
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 161:
> 
>> 159:                     fixedCellSize = p.get();
>> 160:                     fixedCellSizeEnabled = fixedCellSize > 0;
>> 161:                 }
> 
> The `null` check on the property is not needed, properties never return `null`.  I would suggest just calling the getter: `t.getFixedCellSize()`.

good point, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1192534644


More information about the openjfx-dev mailing list