RFR: JDK-8304959: Public API in javafx.css.Match should not return private API class PseudoClassState [v6]

[John Hendrikx]

On Fri, 12 May 2023 22:44:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix PseudoClassTest
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 519:
> 
>> 517: 
>> 518:     @Override
>> 519:     public boolean equals(Object obj) {
> 
> Since you override `equals`, you should also override `hashCode`. Presuming that `super.hashCode` honors the contract of `equals` / `hashCode`, I'd prefer that to be explicit along with a comment as to why it's OK (which you sort of do in a comment in the equals method).

I made it explicit, and slightly reworded the comment. Please note, the equals code that BitSet uses is still broken in this PR, but as fixing it entails more changes to BitSet, and the goal of this PR is to fix a different issue, I've left that for #1076

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1070#discussion_r1192866671