RFR: 8307538: Memory leak in TreeTableView when calling refresh [v6]

[Andy Goryachev]

On Sat, 13 May 2023 17:17:42 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   John is right
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 158:
> 
>> 156:     private void updateCachedFixedSize() {
>> 157:         if (getSkinnable() != null) {
>> 158:             TreeTableView<T> t = getSkinnable().getTreeTableView();
> 
> I know this is a short method, but I would rather see a more descriptive variable name here

I prefer not to drag long names if a very descriptive type is right there: `TreeTableView<T> t`

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java line 161:
> 
>> 159:             if (t != null) {
>> 160:                 double sz = t.getFixedCellSize();
>> 161:                 fixedCellSize = sz;
> 
> Why you don't just assign the variable directly?

fixed, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1194050378
PR Review Comment: https://git.openjdk.org/jfx/pull/1129#discussion_r1194047875