RFR: JDK-8245919: Region#padding property rendering error [v3]

Andy Goryachev angorya at openjdk.org
Mon May 15 16:42:52 UTC 2023


On Sun, 14 May 2023 17:36:12 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> John Hendrikx has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into feature/css-cache-bug
>>  - Fix typo
>>  - Fix bug in CSS caching code that could reset values on unrelated nodes
>>    
>>    The bug occurs due to a cache entry being constructed incorrectly when
>>    the initial node that triggered the cache entry creation has user set
>>    values. The calculated values for properties with a user set value were
>>    omitted in the cache entry, and other nodes that later share the same
>>    entry would incorrectly assume the omitted property was unstyled and
>>    were therefore reset to their default values.
>
> Just tested: This PR also fixes [JDK-8306747](https://bugs.openjdk.org/browse/JDK-8306747). We can probably close it as duplicate of this one then.

@Maran23 : you are right, closed JDK-8306747 as a duplicate.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1072#issuecomment-1548193029


More information about the openjfx-dev mailing list