RFR: JDK-8245919: Region#padding property rendering error [v3]

[John Hendrikx]

On Mon, 15 May 2023 16:41:33 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> John Hendrikx has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into feature/css-cache-bug
>>  - Fix typo
>>  - Fix bug in CSS caching code that could reset values on unrelated nodes
>>    
>>    The bug occurs due to a cache entry being constructed incorrectly when
>>    the initial node that triggered the cache entry creation has user set
>>    values. The calculated values for properties with a user set value were
>>    omitted in the cache entry, and other nodes that later share the same
>>    entry would incorrectly assume the omitted property was unstyled and
>>    were therefore reset to their default values.
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line 1185:
> 
>> 1183:         if (cssValue != null && "inherit".equals(cssValue.getValue())) {
>> 1184:             style = getInheritedStyle(styleable, property);
>> 1185:             if (style == null) return SKIP;
> 
> minor: could we surround return with { }'s please?  To keep one statement per line.

It's not my code originally, I only changed the indent here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1072#discussion_r1194138111