RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]
Ambarish Rapte
arapte at openjdk.org
Tue May 16 10:27:07 UTC 2023
On Fri, 12 May 2023 18:20:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Merge branch 'master' into a11y-8284542-CheckBoxTreeItem
>> - Review Comment: Add enum ToggleState
>> - Add CheckBoxTreeItem role and TOGGLE_STATE attribute
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java line 369:
>
>> 367: AccessibleRole.TREE_ITEM,
>> 368: AccessibleRole.CHECK_BOX_TREE_ITEM,
>> 369: AccessibleRole.TREE_TABLE_ROW
>
> [question] is the order of elements significant in any way?
The order does not matter, the roles are accessed by value on the native side code. (`initEnum()`)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1088#discussion_r1194948439
More information about the openjfx-dev
mailing list