RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]
Ambarish Rapte
arapte at openjdk.org
Tue May 16 10:29:55 UTC 2023
On Fri, 12 May 2023 22:07:31 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> I usually prefer to avoid these sort of unrelated changes to minimize the diffs. Either way is fine.
>
> in this particular case, with many fall-throughs, I think the code would benefit from reformatting.
Minimal diff eases in tracing regression and in review. May be we can take up the cleanup as a separate issue, there seems to be multiple of such instances. (of switch/replacing if with switch)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1088#discussion_r1194954318
More information about the openjfx-dev
mailing list