RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v3]

Alexander Zuev kizune at openjdk.org
Wed May 17 20:23:28 UTC 2023


On Sat, 8 Apr 2023 14:31:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed situation when performAction throws an exception on Java side - now we are properly
>>   returning FALSE notifying system that action has not been performed successfully.
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 120:
> 
>> 118:     (*env)->CallVoidMethod(env, self->jAccessible, jAccessibilityPerformAction, actionId);
>> 119:     GLASS_CHECK_EXCEPTION(env);
>> 120:     return TRUE;
> 
> Are there any cases where an exception is possible? If so, then might checking the exception and returning false if there is one be warranted?

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1084#discussion_r1197010760


More information about the openjfx-dev mailing list