RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v4]

[Alexander Zuev]

On Sat, 8 Apr 2023 14:36:30 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Properly use NSObject instead of the GlassAccessible type.
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line 156:
> 
>> 154:     NSString *roleName = jStringToNSString(env, forRole);
>> 155:     Class classType = [AccessibleBase getComponentAccessibilityClass:roleName];
>> 156:     GlassAccessible* accessible = NULL;
> 
> It might be clearer to use `NSObject` here (which is the common supertype of `GlassAccessible` and `AccessibileBase`).

Fixed.

> modules/javafx.graphics/src/main/native-glass/mac/a11y/ButtonAccessibility.h line 37:
> 
>> 35: - (NSRect)accessibilityFrame;
>> 36: @end
>> 37: 
> 
> Very minor: extra newline at the end of file.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1084#discussion_r1197014453
PR Review Comment: https://git.openjdk.org/jfx/pull/1084#discussion_r1197017319