RFR: JDK-8304959: Public API in javafx.css.Match should not return private API class PseudoClassState [v7]

[Andy Goryachev]

On Wed, 17 May 2023 22:03:31 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 532:
>> 
>>> 530:             return true;
>>> 531:         }
>>> 532:         if (obj instanceof BitSet<?> bitSet) {  // fast path if other is a BitSet
>> 
>> I think we may need to add a 'component type' to BitSet, to make sure than BitSet<A> never intersects with BitSet<B>.
>> 
>> (Didn't we do it already, may be in some other PR?)
>
> We did, in #1076. However, I would like to not pull in all the `BitSet` fixes into this PR as this has nothing to do with `BitSet` and its many problems.

Since it's an internal class, and both PseudoClassState and StyleClassSet are final, checking for class == class is probably sufficient.
Do you think we should add a warning to BitSet, it is not a problem since no-one will ever extend it?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1070#discussion_r1197101958